Attempts to fix the failing specs for shares_controller_spec. #6411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After looking at this spec closer, I see let! was being used to create other documents that should be filtered out from this view. I moved them to a context so they only get created once when they are needed. |
dlpierce
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes rspec failures for
spec/controllers/hyrax/my/shares_controller_spec.rb.Type of change (for release notes)
notes-valkyrieValkyrie ProgressDetailed Description
Swaps out AF factory objects with Valkyrie Monographs.
@samvera/hyrax-code-reviewers